amazon-ecs-render-task-definition icon indicating copy to clipboard operation
amazon-ecs-render-task-definition copied to clipboard

Action does not respect github default working directory

Open Mistobaan opened this issue 3 years ago • 4 comments

Action does not respect github default working directory

image

Previous issues that had to deal with this subtle error: https://github.com/aws-actions/amazon-ecs-render-task-definition/issues/68#issuecomment-881407765

Mistobaan avatar Aug 31 '21 01:08 Mistobaan

@Mistobaan Thank you for raising this issue with us, we will get back to you once we have answer to this issue.

paragbhingre avatar Sep 07 '21 18:09 paragbhingre

Any word on this?

pdehlke avatar May 01 '22 18:05 pdehlke

Any update on this ?

dibyadhar avatar Sep 19 '22 23:09 dibyadhar

Ran into this issue today as well and unfortunately it does not appear this will be something that gets changed.

Right now you either give it an absolute path OR it puts it in the directory attached to the GITHUB_WORKSPACE environment variable.

In case workarounds will help someone in the future you can either:

  1. Write to the environment variable which is at the root of your checked out files (what I'm doing):
- name: Download task definition
  run: |
    aws ecs describe-task-definition --task-definition ${{ env.ECS_TASK_DEFINITION }} --query taskDefinition \
      > ${{ github.workspace }}/task-definition.json

- name: Fill in the new image ID in the Amazon ECS task definition
  id: task-def
  uses: aws-actions/amazon-ecs-render-task-definition@v1
  with:
    task-definition: task-definition.json
    container-name: ...
    image: ...
  1. Write to the temp directory /tmp/task-definition.json (YMMV with what OS you are using)
- name: Download task definition
  run: |
    aws ecs describe-task-definition --task-definition ${{ env.ECS_TASK_DEFINITION }} --query taskDefinition \
      > /tmp/task-definition.json

- name: Fill in the new image ID in the Amazon ECS task definition
  id: task-def
  uses: aws-actions/amazon-ecs-render-task-definition@v1
  with:
    task-definition: /tmp/task-definition.json
    container-name: ...
    image: ...

michaeloyer avatar Dec 07 '23 18:12 michaeloyer