amazon-ecs-deploy-task-definition icon indicating copy to clipboard operation
amazon-ecs-deploy-task-definition copied to clipboard

feat: adds code for showing service event info when using ecs deploy controller

Open felipem1210 opened this issue 2 years ago • 2 comments

Issue #, if available: https://github.com/aws-actions/amazon-ecs-deploy-task-definition/issues/447

Description of changes:

  • Added the new input show-service-events to enable the routine
  • The routine will call describe-ecs-service each amount of seconds seconds to check how is the rolloutState of the deployment.
  • If it is FAILED or IN_PROGRESS but with failedTasksCount more than 0, will detect that the deployment didn't go well, will show the latest events and throw error.
  • If there is a task failed, show the stop reason of the task
  • If it is COMPLETED keep going.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

felipem1210 avatar Feb 05 '23 12:02 felipem1210

Hi @felipem1210,

Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. We will reach-out if with any questions or suggestions during the review.

In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:

  1. Verify if PR follows semantic pull request conventions.

  2. Resolve any conflicts on the PR

  3. Please run npm run package command to update dist/ folder with latest dependencies.

amazreech avatar May 10 '24 19:05 amazreech

What needs to happen to get this merged please? We are running into the issue where we have the deployment circuit breaker enabled and am getting a successful return from the action even when the rollback was initiated. This output would help determine issues.

anitakrueger avatar Feb 27 '25 11:02 anitakrueger