amazon-ecr-login icon indicating copy to clipboard operation
amazon-ecr-login copied to clipboard

[Feature request] Remove dependency on docker client

Open runlevel5 opened this issue 1 year ago • 6 comments

From my understanding in order to perform authentication, the action utilises the docker client to perform docker login. Which is fine. However this dependency will make this plugin incompatible with environment that does not ship docker client (or users could not install any software). IMHO the action should take advantage of the HTTP API endpoint to perform this task instead.

One example I run into is that I run gitub action runners on AWS Lambda & ECS & ECS Fargate environment which lacks the docker CLI. The error output I got is:

Error: Unable to locate executable file: docker. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

runlevel5 avatar Feb 21 '24 02:02 runlevel5

Same here, have a version v2.

szhekpisov avatar Feb 29 '24 12:02 szhekpisov

I am more than happy to offer a Pull Request if the team approves this proposal

runlevel5 avatar Mar 01 '24 05:03 runlevel5

I think this would also solve #434 ?

gricey432 avatar Mar 07 '24 05:03 gricey432

I think this would also solve https://github.com/aws-actions/amazon-ecr-login/issues/434 ?

Yes it would

runlevel5 avatar Mar 08 '24 03:03 runlevel5