Awni Hannun
Awni Hannun
In the named example type you are not doing any array options so compiling through that doesn't make sense. (The `0` and `1` never get cast to `mx.array`. You can...
Cool.. if we include this, I wonder where it would go? I'm not opposed to including it in core or a sub-package but I think there is a decision to...
Is it not the same as `noverlap` in the Scipy implementation? https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.stft.html I think that's a good reference to follow.
@bpkeene left a few minor comments. Could you address? Once updated we can run the tests and get this merged.
You can easily patch MLX with whatever Python function you want: ```Python import mlx.core as np def degrees(radians_array: np.array) -> np.array: return radians_array*(180.0 / np.pi) np.degrees = degrees print(np.degrees(np.array(1.0))) ```...
Nice! I'm glad pre-commit finally supports `.metal`, that's awesome! Could you fix the conflicts and some of the badly formatted kernel instantiations sections? Then we can merge it in.
Looks that kernel isn't being instantiated. Probably you deleted the line that instantiates it or something like that. ``` [metal::Device] Unable to load kernel vselectfloat32 ```
This already has a nearly complete PR in #1011
Could you share the command you are running? Also what OS / machine?
The command should be fine. I don't know why it's not working for you. For some reason Metal isn't JIT compiling for you. It would be useful to know if...