Awni Hannun
Awni Hannun
Hi Manish this looks like a good start! Were you planning to wire the formatting through the python printing code? I think we should keep the printing defaults as they...
> Hi Awni, thanks for the reply. Yes, I did it to format directly while printing. I wanted to make it general as you suggested but I am not sure...
For python changes you should not need to rebuild anything to test. For C++ changes you always need to rebuild to test. The fact that your editable install isn't working...
Looks like it's working well now :) @ManishAradwad is this ready for review again?
Thanks for adding this! I changed a few things around to make it more generalizable for the future. Also I don't know about having the formatting as a global, but...
It is not unsafe, it is just nice to be able to provide a local formatting object so you don't have to change the state of the global object and...
Looks great! A few issues in the docs, please fix and then I think we can merge.
FYI some instructions on building the [docs here](https://github.com/ml-explore/mlx/blob/main/docs/README.md). It's useful to build / look at them for big changes to the docs otherwise you can break them / make strange...
> It would be great if there is a preview environment where you can browse your changes to the docs. This will eliminate the need to this manually. Interesting idea.....
@gboduljak actually I just pushed the docs changes myself since I already made them locally. LGTM, @angeloskath feel free to merge when you are good with it. Thanks for the...