django-shop icon indicating copy to clipboard operation
django-shop copied to clipboard

Bug with endless scrolling when there are has offset

Open execut opened this issue 3 years ago • 6 comments

Steps to reproduce:

  1. Go to catalog list with auto pagination
  2. Add any ?offset=1 to url
  3. Scrolling down is endless

execut avatar Jun 22 '21 08:06 execut

The situation repeats with zero offset. Disabling auto-pagination as if it was more than zero does not help here. It is necessary to refine the javascript to fix the error. I'll fix this error today

execut avatar Jun 23 '21 04:06 execut

Complete

execut avatar Jun 23 '21 04:06 execut

I have a question. Why use rest_framework.pagination.LimitOffsetPagination pagination in ProductListPagination? The rest_framework.pagination.PageNumberPagination would do this nice for it work. And would not entail such a mistake. What is the reason for this?

execut avatar Jun 23 '21 05:06 execut

Why use rest_framework.pagination.LimitOffsetPagination pagination in ProductListPagination?

Because unless you use an explicit paginator, say just next and previous buttons, it is easier to handle.

jrief avatar Jun 25 '21 15:06 jrief

Why use rest_framework.pagination.LimitOffsetPagination pagination in ProductListPagination?

Because unless you use an explicit paginator, say just next and previous buttons, it is easier to handle.

Got it

@jrief What do you think about task? How do you like my solution? Everything is fine?

execut avatar Jun 28 '21 11:06 execut

I have the same with shop system here

runnyren avatar Dec 21 '22 12:12 runnyren