django-shop icon indicating copy to clipboard operation
django-shop copied to clipboard

Reduce the number of things we force onto projects

Open rfleschenberg opened this issue 7 years ago • 1 comments

Right now, we force a lot of things (dependencies and settings) onto projects that want to use django-shop. It is desirable to reduce these requirements.

I am creating this issue as a place to track these things. The plan is not to remove all of these requirements, but to document them and discuss which ones we should remove.

I will update this issue as we discover more things and make progress.

Packages

INSTALLED_APPS

CMS and its requirements:

    'menus',
    'djangocms_text_ckeditor',
    'treebeard',
    'cms',
    'filer',
    'easy_thumbnails',

In addition to that:

    'shop',
    'post_office',
    'cmsplugin_cascade',

Various settings

  • SITE_ID
  • LANGUAGES and LANGUAGE_CODE
  • django.template.context_processors.request in TEMPLATES['OPTIONS']['context_processors']

rfleschenberg avatar Mar 24 '17 23:03 rfleschenberg

I have a question related to this.. In the docs it says we should set EMAIL_BACKEND ='post_office.EmailBackend' but I think this in general isn't desirable. In a production environment you want to be notified as soon as possible of exceptions or problems with the site itself, so having important errors going to the database is undesirable. This would also be a problem if post_office itself developed a problem which prevented all emails from being sent. I also think it's a bad idea to have customer passwords visible by staff in the admin interface.

I understand that customer traffic can/should be delayed/asynchronous.

So my question: is it necessary at the moment to have EMAIL_BACKEND ='post_office.EmailBackend' for Django-SHOP/customer emails? In the notifications code it looks like emails are sent directly to post_office?

EDIT: It looks like I've answered my own question: shop/forms/auth.py: user.email_user(subject, body) Are there any other places?

racitup avatar Oct 19 '17 11:10 racitup