feat: Initialize the Tokio runtime with a custom Tokio runtime

Open rise0chen opened this issue 3 years ago • 3 comments

Initialize the Tokio runtime with a custom Tokio runtime

Oct 12 '22 04:10 rise0chen

Looks good to me, although this might have to wait for pyo3 v0.18 unless there's a good reason to release it earlier. I'm still open to it, so feel free to push for a patch release if you want it.

Oct 21 '22 22:10 awestlake87

TokioRT is an alias of tokio::runtime::Runtime. I changed it back

Oct 21 '22 23:10 rise0chen

TokioRT is an alias of tokio::runtime::Runtime. I changed it back

Oh my bad, you're right. For some reason I thought that was your enum. I think it's fine as a patch. I'll probably add a test for it before releasing it though.

Oct 21 '22 23:10 awestlake87

Hey, I went ahead and merged this into the 0.18 release today. Sorry it's been just sitting here for so long!

Feb 02 '23 02:02 awestlake87