realtek-r8152-dkms icon indicating copy to clipboard operation
realtek-r8152-dkms copied to clipboard

support for d-link e-520 and more from https://github.com/bb-qq/r8152

Open nikitosiusis opened this issue 3 years ago • 7 comments

Good day I suggest using r8152 driver from synology, because it additionally supports more chips, like d-link e-520

nikitosiusis avatar Nov 02 '22 15:11 nikitosiusis

Hello,

Thanks for your contribution :) It'd be nice if it supports more devices. But how can we test if it is working? Do you have Synology? I mean, if it doesn't have any side effects and all the additional codes working fine, I will apply this patch after every update from Realtek.

awesometic avatar Nov 03 '22 03:11 awesometic

I don't have a synology, but I have a d-link e-520(it uses 2.5g rtl8156) . Driver from your repo didn't support it out of the box With driver from bb-rq it started to work. I just replaced the driver in your repo with their driver, to get dkms support. Sadly I cannot test any other adapters :)

nikitosiusis avatar Nov 03 '22 08:11 nikitosiusis

Ah okay,

Then how about making a commit only for supporting the other devices?

Seems this change has other things like: https://github.com/bb-qq/r8152/commit/1f24cbbce59db74f7aeef2458d76ae209c753af4

If you want, you can make a new patch by overwriting this commit using --amend. Or, I can make a new one, and maybe you can help me for the test :)

awesometic avatar Nov 03 '22 08:11 awesometic

Yes, I think we need to amend this commit, because it is not mine actually, but I have no idea how to do it properly:) I just used your repo for dkms module for my d-link e-520 on my laptop. It didn't work, so I got a driver from another repo. Now it works. As far as I understand, other commits to the driver in their repo only affect building on old platforms(kernels?), I believe old platforms don't use dkms :) I can help you with testing, but the only adapter I have is that d-link e-520. I also use your repo for r8125 and it works great.

nikitosiusis avatar Nov 08 '22 14:11 nikitosiusis

Thank you :) I am glad to hear that my r8125-dkms also works great for you.

Then, I will look into the changes to apply only supporting the additional devices. Except supporting old devices.

And I hope you can test my new upcoming builds. :)

awesometic avatar Nov 08 '22 15:11 awesometic