realtek-r8125-dkms icon indicating copy to clipboard operation
realtek-r8125-dkms copied to clipboard

Update README and at Fedora/RedHat installation guide

Open casch-at opened this issue 2 years ago • 2 comments

Hey, I have updated the README a little and also added an installation guide for distributions using dnf/yum as package manager, like Fedora/RedHat. I'm not done yet. Are you interested in this PR? Is there anything I should change....?

Thanks, Christian

casch-at avatar Dec 03 '22 23:12 casch-at

Hello,

Thank you for your contribution. It is really clean and organized well 👍 I looked into your changes and found a few things that I'd like to ask you to consider.

  1. Adding the r8169 module to the blacklist and updating initramfs are required for all methods.

Yeah, those are commonly required things for making r8125 module loaded for sure. Disabling r8169, and letting initramfs know there is the new r8125 module that it should load.

And, this is duplicated with the right below chapter. So that I think 4-iv to 4-viii should be edited along with the very next chapter.

  1. Difference between update-initramfs command and your method?

Adding r8125 driver to the modprobe, which is good to make sure the module loaded, but I can't be sure what is the difference between the update-initramfs command and your instructions.

Is it a more solid way or a special way for Fedora Linux? 🤔

  1. Centered contents in the table might be better ..?

How about this one? I changed the x mark to v, and centered them in the cell.

Nr Method Fedora/RedHat based Debian based
1 deb package v
2 Launchpad PPA v
3 autorun.sh v v
4 dkms-install.sh v (Recommended) v (Recommended)
| Nr | Method          | Fedora/RedHat based | Debian based    |
|----|-----------------|:-------------------:|:---------------:|
| 1  | deb package     |                     | v               |
| 2  | Launchpad PPA   |                     | v               |
| 3  | autorun.sh      | v                   | v               |
| 4  | dkms-install.sh | v (Recommended)     | v (Recommended) |

Please consider my suggestions. Thank you 🙂

awesometic avatar Dec 05 '22 01:12 awesometic

@awesometic Done!

Fedora/RedHat uses the tool dracut instead of the initramfs-tools, but I have no glue why :-)

casch-at avatar Jan 01 '23 18:01 casch-at