gravity-forms-help-scout-search icon indicating copy to clipboard operation
gravity-forms-help-scout-search copied to clipboard

Published 20 hours ago • verified publisher icon awesomemotive

Add a loading spinner once search has been started.

Open danieliser opened this issue 9 years ago • 6 comments
trafficstars

Based on the guide at https://pippinsplugins.com/gravity-forms-help-scout-docs-search-field, if the user is on a slower connection they may get the next button to show a support form before results are displayed.

Adding a loading icon will at least alert them that something is occuring.

This ties in well with #11.

danieliser avatar Jul 01 '16 08:07 danieliser

PR: https://github.com/easydigitaldownloads/gravity-forms-help-scout-search/pull/13

pippinsplugins avatar Jul 02 '16 03:07 pippinsplugins

Already tested it and using it, looks awesome thank you.

danieliser avatar Jul 07 '16 21:07 danieliser

I don't really like the spinner - it makes the search results bounce around too much. Couldn't it have been accomplished using the .docs-searching CSS class?

Just apply the spinner CSS to .docs-searching.docs-search-wrap.

Before, it had a nice slideDown(): jul-25-2016 14-30-20

After, it jumps around:

zackkatz avatar Jul 25 '16 20:07 zackkatz

@zackkatz Hmm, could the spinner just be positioned absolutely over the right side of the search input? That would prevent the jumping.

danieliser avatar Jul 25 '16 20:07 danieliser

Would also look pretty appealing in my mind.

danieliser avatar Jul 25 '16 20:07 danieliser

I didn't actually realize it had the docs searching class. That is very handy.

I like @danieliser's idea of positioning it to the right with absolute position.

How about the following:

  1. Position the spinner absolute and to the right. This will let it display while also not affecting the display of the results.
  2. Style the spinner off of the docs-searching class so that it can be more easily adjusted.

pippinsplugins avatar Jul 25 '16 22:07 pippinsplugins