easy-digital-downloads
easy-digital-downloads copied to clipboard
awesomemotive
Adjust placement of fees in checkout cart
Right now, all fees display on the checkout cart in the same fashion as products. This presents a few problems I can think of:
- It gives the impression that fee amount is factored into the
Subtotal, which displays below the fees. - There are different types of fees used for different reasons. Fees that behave like discounts display in a totally different fashion than actual discounts. It's just inconsistent.
- Nothing about the current display of fees explains what things like taxes or a discount does to the fee itself.
Example, below is a $100 item with a $100 shipping fee and 6.25% tax applied. Tax information is set to display on the cart.
The math is correct when we look at the logic. Looking at the cart, though, you have to know what's going on to understand this. For example, how did taxes affect the fee? How taxes affect the product is clear. For fees, not so much.
I'd like to see a restructuring of this information. Here are some initial points:
- If a fee is a non cart item fee (like an EDD Wallet deposit, which stands alone), it should continue to display where it is but be enhanced to show appropriate information like applied taxes. It should match regular cart item display if it is to be treated as one.
- If a fee is a cart item fee (like a Simple Shipping fee, which is attached to a cart item), it should display below the
Subtotalin a footer row. These fees do not affect the subtotal but instead, make adjustments to the subtotal just like taxes and traditional discounts. - (optional, maybe) If a cart item fee is displayed below the subtotal and is affected by taxes or a discount, it should display such information.
The overall goal is the leave nothing to question about the numbers while avoiding information overload. Right now, though, there just isn't enough information.
Here's a rough mockup of what I'm thinking using the same cart pictured above:
This would require a lot of thought. How to display tax information is the tricky part. It should not be redundant. Likewise, it should not show tax TOTALS prematurely. Showing tax INFO is a different story.
In fact, to help the cart item price actually agree with the subtotal display, I'd even suggest this display when the display taxes in cart setting is on:
(take note that the cart item now shows tax information, not a tax total for the product)
I know this is ugly but I think the display of properly structured cart information should be the first priority.
@easydigitaldownloads/core-devs Thoughts?
Also keep in mind that I used the most basic fee I could apply to make this issue easy to understand. Start talking more complex fees like discounts and you'll see why this is such a big deal.
@SDavisMedia I agree with your reasoning. The separation is necessary to make sense of the cart. The initial screenshot you used above is a perfect example to have the information restructured.
I definitely agree. I am constantly thrown off by the subtotal myself. Screenshot 1 I think is my preferred one.
Gonna drop a note here until we decide whether or not it's a separate issue:
Above, we've mainly discussed fee type fees and how they should adjust the subtotal and be displayed as such. Well, item type fees (EDD Wallet deposit) should continue to display like actual products but they do not currently affect the subtotal.
So this is kind of the same problem but on the other side of the fence.
Just to include some convo from Slack here, there are 2 different types of fees in EDD:
- Item Fees An item fee is a fee that is an item. It acts like a product and is really more of a product than it is a fee.
- Fees A fee is a cost added to the cart because a specific item is in the cart. This would be something like a Shipping fee because a shippable item is in the cart.
The consensus seems to be that Item Fees should be displayed in the cart like any other product/item. In contrast, fees should be listed below the subtotal.
This is spot on @SDavisMedia.
I feel strongly that this should be made a priority for 2.7. We get so many support tickets related to this.
Follow up request: https://secure.helpscout.net/conversation/274131302/46223/?folderId=180499
@SDavisMedia do we need to do much more with this? I'd love to have this one of the earliest major updates to 2.7 so we can make sure that it get's tested throughly.
@cklosowski Nope! I'll start playing with this and see what I can come up with. I'll ping you folks if I need help.
It looks like handling this issue is going to expose a lot of other flaws. I'm going to try to make sure it all gets taken care of, whether I do it here in this issue or if I have to request changes in other issues. I'm gonna be pushing code up but don't consider it done until it's all the way done. I keep running into new walls that make me go back and rework things. Never hesitate to chime in. 👌
Current state of affairs in a very basic cart configuration with taxes, prices exclusive of taxes, tax info displayed at checkout, a fee type fee, and a discount:
This is only the beginning, though. This runs much deeper than checkout cart display.
Just a sidebar I think we should denote top or bottom by a fee checkout location. That leaves us room to introduce actual fee types such as the needed condensed fee (open ticket about this) which is an actual type of fee.
@SDavisMedia in what cases does adjusted by discount(s) show? Anytime there is a negative fee or discount code?
@pippinsplugins only when an EDD core discount is applied to the cart. It will "come and go" as a discount is added or removed. It is also toggled by the "Display during checkout" tax setting alongside the tax info displayed next to the cart item price. Haven't addressed negative fees yet, only core discounts.
It's safe to pull down. Not done but won't error out or anything.
@chriscct7 Is there a need to denote fee location if the fee types are overall treated differently? As in fee type fees are cart adjustments while item type fees are products.
@pippinsplugins sorry, I misspoke. It's true that the adjusted by discount(s) text only displays when a core discount is added. But it is not controlled by that setting. I was thinking of the plus n% tax displayed below the fee, as seen here: https://github.com/easydigitaldownloads/easy-digital-downloads/issues/4833#issuecomment-261793794
I think so, because there's different types of fees that will be in different locations.
For example, a combined vs noncombined fee could be in either location.
On Mon, Nov 21, 2016 at 10:14 AM, Sean Davis [email protected] wrote:
@pippinsplugins https://github.com/pippinsplugins sorry, I misspoke. It's true that the adjusted by discount(s) text only displays when a core discount is added. But it is not controlled by that setting. I was thinking of the plus n% tax displayed below the fee, as seen here: #4833 (comment) https://github.com/easydigitaldownloads/easy-digital-downloads/issues/4833#issuecomment-261793794
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/easydigitaldownloads/easy-digital-downloads/issues/4833#issuecomment-262003421, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQ2XYsxP_qzopKdu4imcPsu1hpxmYZjks5rAdGJgaJpZM4JVfCK .
@sunnyratilal No, this needs to be punted. But I'll hit you in Slack about the reason why.
As per discussion with @SDavisMedia and @cklosowski, this is being punted to 2.8. This issue brings out other discrepancies across EDD which would all need to addressed at once.
@sunnyratilal I don't think it's a good idea to have this in 3.0, unless my perception of the 3.0 timeline is off. I don't want to rush this at all and I want as much testing and feedback as possible. I'd have to start fresh now that the data source is different, though I'd probably go down the same design path. But that was almost 2 years ago... so I want to approach it fresh again.
If this can wait until shortly after 3.0, I think that would be best.
Customer request, reporting the subtotal is confusing when a fee (recurring fee) is in the cart. https://secure.helpscout.net/conversation/1233005582/160695
