EDD-License-handler icon indicating copy to clipboard operation
EDD-License-handler copied to clipboard

Why override 'pre_set_site_transient_update_plugins' array param with object?

Open champsupertramp opened this issue 8 years ago • 0 comments

Hi @pippinsplugins,

I'd like to know why it checks for object arguments when this filter pre_set_site_transient_update_plugins returns array? http://hookr.io/filters/pre_set_site_transient_update_plugins/#usage

I found an issue where it swaps the existing passed array with an object that's why it always lookup for an update on every load of the /plugin.php page and disrespects the last_time expiration when checking in transient? https://github.com/easydigitaldownloads/EDD-License-handler/blob/master/EDD_SL_Plugin_Updater.php#L83

https://github.com/easydigitaldownloads/EDD-License-handler/blob/master/EDD_SL_Plugin_Updater.php#L138

champsupertramp avatar Mar 16 '16 10:03 champsupertramp