awesome icon indicating copy to clipboard operation
awesome copied to clipboard

feat(hotkeys_popup): add override_label_bgs option for consistent lab…

Open JimmyCozza opened this issue 5 months ago • 3 comments

…el colors

Add beautiful.hotkeys_override_label_bgs option that, when set to true, applies hotkeys_label_bg to all group labels instead of cycling through xresources colors. This provides users with full control over label background colors for a more consistent appearance.

Fixes #3773

JimmyCozza avatar Jul 24 '25 17:07 JimmyCozza

@Aire-One I rebased and force pushed. Still not seeing the CI checks running, but I wonder if that's because I'm a new contributor and need the approval for workflows.

Either way, let me know if there's anything more I can do here.

JimmyCozza avatar Oct 10 '25 05:10 JimmyCozza

Codecov Report

:x: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.53%. Comparing base (7263f64) to head (29dd7e7).

Files with missing lines Patch % Lines
lib/awful/hotkeys_popup/widget.lua 0.00% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4017      +/-   ##
==========================================
+ Coverage   54.41%   54.53%   +0.12%     
==========================================
  Files         264      263       -1     
  Lines       31259    31263       +4     
  Branches     1149     1149              
==========================================
+ Hits        17009    17049      +40     
+ Misses      13739    13703      -36     
  Partials      511      511              
Files with missing lines Coverage Δ
lib/awful/hotkeys_popup/widget.lua 40.93% <0.00%> (-0.65%) :arrow_down:

... and 10 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 10 '25 08:10 codecov[bot]

@Aire-One I rebased and force pushed. Still not seeing the CI checks running, but I wonder if that's because I'm a new contributor and need the approval for workflows.

Either way, let me know if there's anything more I can do here.

Yes, we need to approve for the CI to run on new contributors PRs.

Checking lib/awful/hotkeys_popup/widget.lua       1 warning

    lib/awful/hotkeys_popup/widget.lua:294:121: line is too long (126 > 120)

This will need to be fixed.

Aire-One avatar Oct 10 '25 11:10 Aire-One