awesome icon indicating copy to clipboard operation
awesome copied to clipboard

ruled.notifications remove mistaken code example line

Open elig0n opened this issue 1 year ago • 4 comments

  1. The second code example on ruled.notifications has what seems to be an extra unneeded line at the end:
naughty.connect_signal("request::display", function(n)
    naughty.layout.box { notification = n }
end)
    icon      = beautiful.awesome_icon,

In the source file it appears to come from a later, separate creation of a notification which doesn't appear in any doc. I assume it is supposed to be hidden altogether.

  1. The app_name string mdp appear several times in the file. I couldn't find such app, is it actually meant to be mpd ? Let me know and I will push a commit changing it

elig0n avatar Oct 15 '24 07:10 elig0n

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.27%. Comparing base (d53eb1b) to head (06901a9). Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3967      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files         936      936              
  Lines       60149    60149              
==========================================
- Hits        54902    54898       -4     
- Misses       5247     5251       +4     
Flag Coverage Δ
gcov 91.27% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/examples/wibox/nwidget/rules/widget_template.lua 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

codecov[bot] avatar Oct 15 '24 07:10 codecov[bot]

As a heads-up for future contributions: Small documentation fixes like you've been doing recently don't really warrant a separate, dedicated PR for each. Instead, by merging them like in for example #3529 (i.e. separate commits in a single PR) you can reduce the burden on reviewers.

sclu1034 avatar Oct 16 '24 22:10 sclu1034

for me small PRs are alright

actionless avatar Oct 18 '24 18:10 actionless

and regarding mpd/mdp

the only mdp player i found is this one below, mb it meant to have a remote control widget for it 🙃

2024-10-18--1729278235_535x667_scrot

actionless avatar Oct 18 '24 19:10 actionless