awesome icon indicating copy to clipboard operation
awesome copied to clipboard

Notification always executes the action

Open ayushjaipuriyar opened this issue 1 year ago • 8 comments

awesome v4.3-1655-gad0290bc1-dirty (Too long)
 • Compiled against Lua 5.4.7 (running with 0.9.2)
 • API level: 4
 • D-Bus support: yes
 • xcb-errors support: no
 • execinfo support: yes
 • xcb-randr version: 1.6
 • LGI version: /usr/share/lua/5.4/lgi/version.lua
 • Transparency enabled: yes
 • Custom search paths: no

How to reproduce the issue:

  • A notification from any app that supports actions, let's say slack.

Actual result:

  • As soon as the notifications arrives, the app is forced to open even when no actions were taken.

Expected result:

  • The notification should just time out if no actions are taken.

This wasn't the case earlier, but in the recent commits this started to happen.

ayushjaipuriyar avatar Aug 22 '24 05:08 ayushjaipuriyar

Can you check with bustle is the action is indeed taken rather than this being something else? Also, do you use the legacy notification module or the new one (aka, do you have a naughty.connect_signal("request::display"... section in your config, which indicates the new one is used)

Elv13 avatar Aug 22 '24 10:08 Elv13

Can you check with bustle is the action is indeed taken rather than this being something else? Also, do you use the legacy notification module or the new one (aka, do you have a naughty.connect_signal("request::display"... section in your config, which indicates the new one is used)

I am using the new one, as I have that line in my configs. And yes in bustle, it shows like

  • Notifications arrived
  • 3 seconds have passed, the time I have set as timeout of notifications
  • The notification actions invoked is called
  • the notifications action closed is called.

ayushjaipuriyar avatar Aug 22 '24 10:08 ayushjaipuriyar

I'm on current master and I've noticed that even when you right click on the notification (used to just close it) now it execute the action anyway. Might be related?

numkem avatar Aug 26 '24 14:08 numkem

I'm on current master and I've noticed that even when you right click on the notification (used to just close it) now it execute the action anyway. Might be related?

could be we might have been able to figure out which may be causing this Reddit link pull request

ayushjaipuriyar avatar Aug 26 '24 16:08 ayushjaipuriyar

I think https://github.com/awesomeWM/awesome/pull/3906 tries to fix this behavior.

Aire-One avatar Aug 27 '24 00:08 Aire-One

I merged the PR, please update and retry

Elv13 avatar Aug 27 '24 09:08 Elv13

I merged the PR, please update and retry

Apparently did not fix the issue. Currently, as soon as the timeout of the notification finishes the action is executed.

ayushjaipuriyar avatar Aug 27 '24 13:08 ayushjaipuriyar