awesome icon indicating copy to clipboard operation
awesome copied to clipboard

Dismiss the notification without triggering default action on right-click

Open danimateo opened this issue 1 year ago • 2 comments

This is an improvement to the problem presented by @BarbUk 's comment here: https://github.com/awesomeWM/awesome/pull/3863#issuecomment-1759421092

On right click, the notification dismisses without triggering the default action. On left click, behavior is the same as until now.

danimateo avatar Mar 27 '24 17:03 danimateo

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.27%. Comparing base (8b1f895) to head (01b0652). Report is 10 commits behind head on master.

Files Patch % Lines
lib/naughty/layout/box.lua 50.00% 3 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3906   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         935      935           
  Lines       60129    60130    +1     
=======================================
+ Hits        54880    54883    +3     
+ Misses       5249     5247    -2     
Flag Coverage Δ
gcov 91.27% <50.00%> (+<0.01%) :arrow_up:
luacov 93.90% <50.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/naughty/layout/box.lua 94.19% <50.00%> (+0.03%) :arrow_up:

... and 2 files with indirect coverage changes

codecov[bot] avatar Mar 28 '24 06:03 codecov[bot]

Bump, could this be merged if it's approved by everyone? There is currently no easy way to dismiss notifs without the notifying app getting focused.

wereii avatar May 09 '24 13:05 wereii

Thanks for this. Sorry for the delay, I didn't have time for Awesome over the last year and built a huge backlog of things to look at.

Elv13 avatar Aug 27 '24 09:08 Elv13

@Elv13 no worries, thank you very much for the continued work!

wereii avatar Aug 27 '24 10:08 wereii