FontAwesome.Sharp icon indicating copy to clipboard operation
FontAwesome.Sharp copied to clipboard

Duplicate IconChar entries in property window.

Open Sensei6x9 opened this issue 1 year ago • 8 comments

Describe the bug There are some duplication of IconChars in the property window.

To Reproduce Steps to reproduce the behavior:

  1. Create VB.Net (BASIC) Project
  2. Install FA.Sharp v6.1.1
  3. Add IconButton
  4. Navigate to IconChar in property window.
  5. See Error (duplicate IconChars i.e. DollarSign, FloppyDisk, etc.)

Expected behavior Information on why there are duplicates and maybe deletion of the said duplicates.

Screenshots image image

Sensei6x9 avatar Aug 06 '22 14:08 Sensei6x9

Hi @Sensei6x9 ,

I can see duplicate enum values for DollarSign in IconChar.cs as well as in the Professional-icons (DuoTone, ProIcons), cf.:

  • https://github.com/awesome-inc/FontAwesome.Sharp/search?q=DollarSign

FloppyDisk only found once in code.

Will check on reproducing the bug.

mkoertgen avatar Aug 08 '22 07:08 mkoertgen

Thanks @mkoertgen . I'm using only the free one, I guess that why I can only use one of those duplicates.

Sensei6x9 avatar Aug 10 '22 08:08 Sensei6x9

I can confirm this reproducing it using VS2022 / WinForms net6-windows and the latest NuGet package

Lots of duplicate all through the collection image

mkoertgen avatar Aug 11 '22 09:08 mkoertgen

Added a unit test reproducing the error. In fact Enum.GetValues(...). -> ToString() may produce lots of duplicates.

mkoertgen avatar Aug 11 '22 09:08 mkoertgen

I don't know what to do from here on out.... still new to github and I'm only here because of your awesome icons (thanks btw)

Sensei6x9 avatar Aug 17 '22 08:08 Sensei6x9

Hi @Sensei6x9 ,

No problem, thanks for bringing this to my attention. The bug is fixed, yet for the next release I wanted to compile some other fixes as well.

See milestone 6.1.2 which should be released by this week.

Ok for you?

mkoertgen avatar Aug 17 '22 12:08 mkoertgen

I see, yeah that's great. Thank you so much.

Sensei6x9 avatar Aug 17 '22 15:08 Sensei6x9

The issue is still apparent in a different form. Not sure if you fixed it elsewhere, but the main branch still has duplicate entries. image image

(Note that this is only an intellisense error and compiles just fine)

duckdoom5 avatar Jan 27 '24 19:01 duckdoom5