FontAwesome.Sharp
FontAwesome.Sharp copied to clipboard
Duplicate IconChar entries in property window.
Describe the bug There are some duplication of IconChars in the property window.
To Reproduce Steps to reproduce the behavior:
- Create VB.Net (BASIC) Project
- Install FA.Sharp v6.1.1
- Add IconButton
- Navigate to IconChar in property window.
- See Error (duplicate IconChars i.e. DollarSign, FloppyDisk, etc.)
Expected behavior Information on why there are duplicates and maybe deletion of the said duplicates.
Screenshots
Hi @Sensei6x9 ,
I can see duplicate enum values for DollarSign in IconChar.cs
as well as in the Professional-icons (DuoTone, ProIcons), cf.:
- https://github.com/awesome-inc/FontAwesome.Sharp/search?q=DollarSign
FloppyDisk
only found once in code.
Will check on reproducing the bug.
Thanks @mkoertgen . I'm using only the free one, I guess that why I can only use one of those duplicates.
I can confirm this reproducing it using VS2022 / WinForms net6-windows and the latest NuGet package
Lots of duplicate all through the collection
Added a unit test reproducing the error. In fact Enum.GetValues(...). -> ToString()
may produce lots of duplicates.
I don't know what to do from here on out.... still new to github and I'm only here because of your awesome icons (thanks btw)
Hi @Sensei6x9 ,
No problem, thanks for bringing this to my attention. The bug is fixed, yet for the next release I wanted to compile some other fixes as well.
See milestone 6.1.2 which should be released by this week.
Ok for you?
I see, yeah that's great. Thank you so much.
The issue is still apparent in a different form. Not sure if you fixed it elsewhere, but the main branch still has duplicate entries.
(Note that this is only an intellisense error and compiles just fine)