Arne Welzel
Arne Welzel
> until @awelzel helpfully suggested having the variable be an option and using Config::set_value to make and propagate the update Yeah, if the variable semantically isn't an option, it's not...
Thanks for the PR. Pinging @Neverlord - appears that `broker::to_string()` returns `std::string` containing null-bytes. Specifically judging by how it had been used in `Manager::RenderMessage`, this seems unexpected. I do wonder...
> Seems like the null bytes are generated by Zeek in the Broker Manager: > https://github.com/zeek/zeek/blob/master/src/broker/Manager.cc#L828. On line 810, Zeek constructs a String basically from raw bytes plus size from...
> Only took a quick look here, but I think I can see having to_string() escape non-printable character automatically, but we'd need to see that all callers of the function...
> What's the status on this PR? It's been a couple of months since the last comment. I had hoped for you / @rsmmr to chime in. The can of...
> It didn't trigger with the dev build I have lying around, but didn't try very hard, but maybe something was fixed here? It does trigger with the latest master,...
> @awelzel can you see if you can reproduce it still? Doesn't reproduce here either. We can close it, though I don't quite get how #2332 fixed it :-)
Ah, nope, still reproduces. I think the timings involved just got much better with the #2332, but the actual problem is still there: Changing this in `event loop()`: ``` -...
> Isn't 0.0001 sec causing Zeek to basically run in a hot loop? Do you see memory piling up during the run? I would expect that writing to a Broker...
> However, I've also played a bit with expire_persistence_ival. This parameter ultimately tells Broker the expiration time for each time, right? When increasing this to 10s, then the first Zeek...