Alexander Wels
Alexander Wels
Just to add my 2 cents to this conversation. We want to store somewhere the names of the old volumes in a persistent fashion. The VMI is not suitable for...
So I just fixed the same thing here: https://github.com/kubevirt/kubevirt/pull/13039 note that the length check is not actually needed. `naming.GetName` actually just returns the name if it is short enough.
Also note we use the vmexport name in the export server pod template, and it needs to be fixed there as well otherwise it will not create pod properly.
> @awels > > Am I misreading https://github.com/openshift/library-go/blob/master/pkg/build/naming/namer.go#L19-L22 - which would return the "{base}-{suffix}"? Right but all the created resources (pod/service/etc) all have a prefix, so we would want the...
@mhenriks @alicefr The preserve the label instead of adding the prefix is probably a non issue. I don't care that much either way. But we will have two different formats...
So definitely need to also make sure the template containers does the same thing. in my test environment if I leave as vmExport.Name I get the following error: ``` E1009...