Alexander Wels comments

Results 481 comments of


                                            Alexander Wels

Enable automatic token generation for VirtualMachineExport objects

/hold /lgtm Putting hold to give others chance to review, if no reviews in a few days I will remove the hold

Enable automatic token generation for VirtualMachineExport objects

/hold cancel

Improve WFFC handling by removing the dummy pod step

So let me see if I understand this correctly. Instead of the dummy pod, you want to just start the virt-launcher pod normally, but not start the VM process until...

Improve WFFC handling by removing the dummy pod step

Yes, I think that would be the appropriate approach.

Improve WFFC handling by removing the dummy pod step

/lifecycle frozen

Fix hotplug with disk mutating sidecar; add integration tests

Seem like some problem with the functional tests, I see the storage lanes are failing on the 3 new hotplug tests

Fix hotplug with disk mutating sidecar; add integration tests

Sorry been on PTO for last 2 weeks, will try to look on Monday.

Fix hotplug with disk mutating sidecar; add integration tests

@mhenriks could you review this PR?

Fix hotplug with disk mutating sidecar; add integration tests

/test pull-kubevirt-goveralls

Fix hotplug with disk mutating sidecar; add integration tests

Don't worry about the fossa right now, its not required and we have an outstanding issue with it.