powerbi-vcs
powerbi-vcs copied to clipboard
awaregroup
handle `modifiedTime` nicely
See #7 - often small changes get obscured by e.g. modifiedTime changing. Can we handle this nicely so that e.g. it's not shown in the diff? I think there might be ways using filters to strip out patterns and hence ignore them from the diff.
Hi - I appreciate this issue is 3 years old, however I've been doing a bit of work recently based on a fork of this project. Part that was ignoring the date-changes, which improves diff/merge no-end. It's actually proving really useful for us, so would like to contribute back - however I've done a fair few changes so they don't necessarily fit a PR contribution model. If you're interested, would it be OK to have a chat to look at how I could help out here?
Wow, thanks @andy-clapham - great to know it's useful, and you're willing to contribute back!
I've done a fair few changes so they don't necessarily fit a PR contribution model. If you're interested, would it be OK to have a chat to look at how I could help out here?
Definitely. To be honest, this hasn't received any love for years, so I'm very happy with the "I just rewrote everything" sort of PR = ) We could even just merge in what you've currently got. Would that work for you?
Sounds great!
I’d like to polish a bit as I do commit rather frequently and chattily, so I’d probably want to rearrange my commits a bit to make them more public facing I’m also “Mr TDD” so ahem… would like to live up to my name and add some tests for each feature. Nothing like rewriting history, eh! And the json rewriting is a visitor pattern, so would want to clean up my cut & paste coding. Hey, nobody’s perfect 😊
Give me couple of weeks or so (you know what side-of-desk projects are like!), and I’ll send through a PR.
From: kodonnell [email protected]
Sent: 12 February 2021 08:22
To: awaregroup/powerbi-vcs [email protected]
Cc: Andy Clapham [email protected]; Mention [email protected]
Subject: [EXTERNAL]Re: [awaregroup/powerbi-vcs] handle modifiedTime nicely (#8)
CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Wow, thanks @andy-claphamhttps://github.com/andy-clapham - great to know it's useful, and you're willing to contribute back!
I've done a fair few changes so they don't necessarily fit a PR contribution model. If you're interested, would it be OK to have a chat to look at how I could help out here?
Definitely. To be honest, this hasn't received any love for years, so I'm very happy with the "I just rewrote everything" sort of PR = ) We could even just merge in what you've currently got. Would that work for you?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/awaregroup/powerbi-vcs/issues/8#issuecomment-778050466, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQENT76JS6STHAOKK2JAWCTS6TQLLANCNFSM4ELKB4DQ.
I’d like to polish a bit as I do commit rather frequently and chattily, so I’d probably want to rearrange my commits a bit to make them more public facing
Sure - but if you want to take the lazy route and squash them, that's fine with me. My commit messages aren't exactly something to be proud of anyway = )
I’m also “Mr TDD” so ahem… would like to live up to my name and add some tests for each feature.
That'd be awesome! I'm mostly keen on a bunch of integration tests, as then we can actually say "we've tested this on a variety of PowerBI files and diffs, and it actually works!" sort of thing, which might help to give confidence to others wishing to use it, including in commercial settings.
It's actually proving really useful for us
Just on this - it'd be awesome to have a bit of an idea about how you use it and how it improves things in a real-world scenario etc. Could just be a documentation of the 'recommended workflow' in the readme, or a blog/video/etc. Definitely not a requirement, just keep it in the back of your mind if anything easy jumps out at you. The readme seems a bit unhelpful at the moment - lots of TODOs etc.
Sounds great! I’d like to polish a bit as I do commit rather frequently and chattily, so I’d probably want to rearrange my commits a bit to make them more public facing I’m also “Mr TDD” so ahem… would like to live up to my name and add some tests for each feature. Nothing like rewriting history, eh! And the json rewriting is a visitor pattern, so would want to clean up my cut & paste coding. Hey, nobody’s perfect 😊 Give me couple of weeks or so (you know what side-of-desk projects are like!), and I’ll send through a PR. From: kodonnell [email protected] Sent: 12 February 2021 08:22 To: awaregroup/powerbi-vcs [email protected] Cc: Andy Clapham [email protected]; Mention [email protected] Subject: [EXTERNAL]Re: [awaregroup/powerbi-vcs] handle
modifiedTimenicely (#8) CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Wow, thanks @andy-claphamhttps://github.com/andy-clapham - great to know it's useful, and you're willing to contribute back! I've done a fair few changes so they don't necessarily fit a PR contribution model. If you're interested, would it be OK to have a chat to look at how I could help out here? Definitely. To be honest, this hasn't received any love for years, so I'm very happy with the "I just rewrote everything" sort of PR = ) We could even just merge in what you've currently got. Would that work for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQENT76JS6STHAOKK2JAWCTS6TQLLANCNFSM4ELKB4DQ.
I realize this has been a while, but I'm just now looking for this type of capability for a small PBI dev team. Were you able to get your version up into a repo, or perhaps have a PR ready? Thanks.
