proto3-suite icon indicating copy to clipboard operation
proto3-suite copied to clipboard

Move AST to separate package

Open riz0id opened this issue 3 years ago • 2 comments

This PR isolates Proto3.Suite.DotProto.AST into separate package proto3-suite-ast.

riz0id avatar Feb 13 '22 07:02 riz0id

The original request for this was from quite a while ago so I wanted to check if we still need to split this out into a separate package?

I do think there is a good reason to split into multiple packages, but for a different reason: I think there should be a package that implements the code generation logic and the generated code should depend on a separate package. However, I don't believe separating out the AST into a separate package addresses that.

Gabriella439 avatar Feb 14 '22 21:02 Gabriella439

I can't think of a reason why the syntax datatype would be useful in a separate package even if I went ahead and added the parser into the new package. I don't mind removing the new package, but I do think that some of the changes in this PR like documentation, removing orphan instances out of Proto3.Suite.DotProto.Rendering, and the new modules compartmentalizing things a bit more are useful though.

riz0id avatar Feb 14 '22 21:02 riz0id