Allen Wittenauer

Results 29 comments of Allen Wittenauer

At some point we need to remove the -findbugs from both the docs here and in the actual action but that is no big deal. Thanks @sekikn !

I'm going to go ahead and merge this in. Thanks for the contribution @sekikn !

I've hit this issue many, many times--but not consistently--with m4v files, all with audio encoded in ALAC. So it seems to be a bug inherent to the algorithm rather than...

For anyone that cares, here's a fix for the freeform fields bug: https://github.com/whatsnowplaying/audio-metadata/commit/920b2bfde57a16292214afdf2660d43e572eafd5

> Is there a way to reproduce this without running a Redis instance? I get a ConnectionError. I'm seeing it using fakeredis, which is what I use to test redis...

> > I'm seeing it using fakeredis, which is what I use to test redis code. > > Any chance you can give us a way to reproduce it? This...

Definitely optional and almost certainly off by default. Some of us actually check our return codes to do appropriate actions and expecting, e.g., a global set -e does more harm...

Without an await somewhere, it is still holding the execution lock.

I can't think of any other info that would be useful that would be in the purview of TinyTag. e.g., image size, image type, etc, are better handled by something...

> mime_type and picture_type are included because ID3 provides them, but I haven't looked into what other formats do. I wonder how reliable those fields actually are. In my particular...