AvS_FastSimpleImport icon indicating copy to clipboard operation
AvS_FastSimpleImport copied to clipboard

Integrate Importer refactoring

Open pixelhed opened this issue 7 years ago • 4 comments

integrate refactoring done by @sprankhub in #393

pixelhed avatar Oct 17 '18 05:10 pixelhed

@sprankhub can you check to see if this integrates what you did correctly please?

pixelhed avatar Oct 17 '18 05:10 pixelhed

Thanks @pixelhed! Most of the stuff looks good. Anyway, are you sure that this works correctly? I am missing the part, where link_type = file is used:

https://github.com/avstudnitz/AvS_FastSimpleImport/pull/393/files#diff-f8e8d5f37e9620023fd30064b683d27bR2065

I did not test though, I just did a code review.

sprankhub avatar Oct 17 '18 06:10 sprankhub

I am missing the part, where link_type = file is used:

if you look here: https://github.com/avstudnitz/AvS_FastSimpleImport/blob/bd9f2e814c1c35bb604b04ee585dcc1dbf19875a/src/app/code/community/AvS/FastSimpleImport/Model/Import/Entity/Product.php#L2106

you will see that it is set depending upon the type of link being imported.

pixelhed avatar Oct 17 '18 06:10 pixelhed

Okay awesome. As said, I could not test it, but you tested it, right? Did you also verify that imported downloadable files are structured in the way Magento does it usually (in subfolder à la /t/e/test.zip). If yes, I am happy to merge :-)

sprankhub avatar Oct 17 '18 12:10 sprankhub