AvS_FastSimpleImport icon indicating copy to clipboard operation
AvS_FastSimpleImport copied to clipboard

Replace Usage of @ For Error Suppression

Open sprankhub opened this issue 8 years ago • 0 comments

In AvS_FastSimpleImport_Model_Import_Entity_Product::_getUploader and AvS_FastSimpleImport_Model_Import_Entity_Product::_getDownloadableUploader respectively, the @ is used to suppress errors. This should be avoided. A proper exception should be thrown if there is an issue. Additionally, if the directory is not writable, we should probably do a chmod instead of a mkdir.

sprankhub avatar Jul 21 '17 06:07 sprankhub