avr-libc icon indicating copy to clipboard operation
avr-libc copied to clipboard

[bug #37627] #define PA0_DDR DDRADC without ever defining DDRADC

Open avrs-admin opened this issue 3 years ago • 1 comments

Wed 24 Oct 2012 05:13:11 PM CEST

A number of header files contains macros definitions like: #define PA0_DDR   DDRADC #define PA0_PORT  PORTADC #define PA0_PIN   PINADC #define PA0_BIT   ADC0 or #define PCINT1_DDR   DDRADC #define PCINT1_PORT  PORTADC #define PCINT1_PIN   PINADC #define PCINT1_BIT   ADC1

without ever defining DDRADC, PORTADC, ADC0...

I assume these lines were supposed to read: #define PA0_DDR   DDRA #define PA0_PORT  PORTA #define PA0_PIN   PINA #define PA0_BIT   0 ??

This applies to all device pin definitions in: avr/iotn861a.h avr/iom88pa.h avr/iotn20.h avr/iotn461a.h avr/iotn40.h avr/iotn261a.h

This issue was migrated from https://savannah.nongnu.org/bugs/?37627

avrs-admin avatar Jan 31 '22 00:01 avrs-admin

Wed 24 Oct 2012 07:40:17 PM CEST

I have found some more...

In avr/iom16hva2.h: #define NV_DDR   DDRNV #define NV_PORT  PORTNV #define NV_PIN   PINNV #define NV_BIT   NV and following lines don't seem right to me either.

Also: avr/iom16hvb.h avr/iom16hvbrevb.h avr/iom32hvb.h avr/iom64hve.h

avrs-admin avatar Jan 31 '22 00:01 avrs-admin