Avi Shukron

Results 12 comments of Avi Shukron

Sure, thanks! Please hold the release of 3.0 until the weekend, I might have some more small fixes to push.

I totally forgot about this... If it is still relevant you can absolutely merge this.

In that case maybe `validators.PythonRegex` class might make sense since we *do* want to actually validate the value.

Will work on that soon. In any case the lack of this validator is not a big deal since the library enables anyone to write such validator themselves

I think this PR should be closed since it is followed by #108 which fixes the issues with this PR.

List of floats: ```python class MyModel(models.Base): list_of_floats = fields.ListField(float) ``` Not sure about float matrix.

Well - although you can set additional **attributes** to an instance, these attribute won't make it to the actual JSON. ```py from jsonmodels.models import Base from jsonmodels.fields import * class...

That would be very useful. Right now you have to subclass each field of which you want to provide a default value.

I did not add the necessary `default` keyword to the schema when I implemented this issue. @beregond - where is the schema generation is done in the code?