react-shortcuts icon indicating copy to clipboard operation
react-shortcuts copied to clipboard

Apply more conventional code style linting

Open greena13 opened this issue 6 years ago • 1 comments

This repository has some pretty unconventional linting. To encourage contributions from the community and to make it easier to read and maintain the source code, I took a look at the linting rules of some of the most popular react projects:

https://github.com/kriasoft/react-starter-kit/blob/master/.eslintrc.js https://github.com/callemall/material-ui/blob/v1-beta/.eslintrc.js https://github.com/facebook/react/blob/master/.eslintrc.js

And removed any rules that I saw as noticeable deviations from what seems to be a pretty safe proxy for community standard.

I then ran

node_modules/.bin/eslint --fix --ext .js .

To autofix all JS files with the new linting rules and fixed any refactoring that could not be performed automatically.

There are still linting issues with the test files, but I am planning on addressing those in a subsequent pull request.

greena13 avatar Oct 16 '17 18:10 greena13

Maybe Prettier can be added too.

kumarharsh avatar May 08 '18 08:05 kumarharsh