avocado icon indicating copy to clipboard operation
avocado copied to clipboard

Cache interface

Open richtja opened this issue 3 years ago • 1 comments

This is an initial PR which crates avocado cache interface. It introduces new plugin "Cache" which will be responsible for manipulating with cache, and it's representation through avocado interface. This PR also adds vmimage cache and requirements cache to this interface.

For now, it supports only listing of cache entries, but it is possible to expand for features like prune or edit.

Reference: https://github.com/avocado-framework/avocado/issues/5453 Signed-off-by: Jan Richter [email protected]

richtja avatar Aug 18 '22 12:08 richtja

Hi @richtja, this looks good, thanks!

Besides the typo, I think the CLI syntax/interface is not prepared for the future extensibility you described. The current functionality is all about a list sub-command, and as such, should require that explicitly.

Then, the CACHE_TYPE parameter should also become a non-positional argument IMO: it's more explicit and allows for better extensibility in the future.

@clebergnu thanks for your review I did fix via force-push, please have a look.

richtja avatar Aug 24 '22 12:08 richtja