Drop legacy runner / loader

[clebergnu]

Is your feature request related to a problem? Please describe. The nrunner based architecture is already the default for Avocado, but the legacy runner and loader code needs to be completely removed.

There are a few features that need/could/should be implemented in the nrunner architecture to make it as much as a drop in replacement as possible.

Describe the solution you'd like Have most legacy runner features (unless architecture conflicts) under the nrunner.

Describe alternatives you've considered Not implement the features, but that is not desirable.

Additional information The following issues are related to this epic:

• https://github.com/avocado-framework/avocado/issues/3882
• https://github.com/avocado-framework/avocado/issues/5137

[PraveenPenguin]

@clebergnu can we delegate this task please , like removing legacy runner for a couple of more months as you know avocado-misc test repo we had coded as considering that the avocado job runs in sequential and we going to evaluate how we can par with nrunner. And we are also desperate to inline with nrunner complaint but will ACK you shortly how that shape out

[clebergnu]

@clebergnu can we delegate this task please , like removing legacy runner for a couple of more months as you know avocado-misc test repo we had coded as considering that the avocado job runs in sequential and we going to evaluate how we can par with nrunner. And we are also desperate to inline with nrunner complaint but will ACK you shortly how that shape out

Hi @PraveenPenguin,

I understand your point, but there are a number of possibilities for the avocado-misc-test repo. For instance, you can run tests sequentially with nrunner, simply set --nrunner-max-parallel-tasks=1. Also, the purpose of the LTS release is to allow for features to be relied on for a long time, and that includes the legacy runner / loader.

Let me know if you find issues with any of these approaches and we can evolve the conversation.

[PraveenPenguin]

@clebergnu thanks for the help , but as said we want to par with nruuner use so we get benefit with on going Development , while initial analysis of misc test repo is just a high-level request can we have implantation on nrunner call as running multiple tests in the single command line and we should able to run the specified test in serial mode and others go in parallel . Apart from this maybe we have more requests will compile all of them and send you shortly and looking for help on the same front

[philmd]

FWIW mainstream QEMU still heavily uses the legacy runner: https://gitlab.com/qemu-project/qemu/-/blob/v7.2.0-rc0/tests/Makefile.include#L141

[clebergnu]

Hi @philmd,

We made sure nrunner works fine with the QEMU tests. I'm about to send a patch series bumping Avocado in QEMU to the latest release (99.0).

I'm only waiting on a CI job before sending the patches.

[philmd]

We made sure nrunner works fine with the QEMU tests. I'm about to send a patch series bumping Avocado in QEMU to the latest release (99.0).

Thanks! Right now using 88.1 with nrunners triggers a bug on Darwin where the cachedirs being sometime None. I'll wait for your series and test it on Darwin before reporting that.

[clebergnu]

We made sure nrunner works fine with the QEMU tests. I'm about to send a patch series bumping Avocado in QEMU to the latest release (99.0).

Thanks! Right now using 88.1 with nrunners triggers a bug on Darwin where the cachedirs being sometime None. I'll wait for your series and test it on Darwin before reporting that.

Hi @philmd, a quick update here. I've caught one issue that is regressing functionality used in QEMU in Avocado 99.0, so I've held the update to have a fully functional bump to (upcoming) Avocado 100.0.

Sorry for the delay, though.

[philmd]

Hi @philmd, a quick update here. I've caught one issue that is regressing functionality used in QEMU in Avocado 99.0, so I've held the update to have a fully functional bump to (upcoming) Avocado 100.0.

Thanks for the update :)

[clebergnu]

The legacy runner and loader have been completely removed, so the main topic issue here is resolved. Issue #3882 is related but not a requirement of this issue.

[clebergnu]

The legacy runner and loader are completely removed at this point. A feature that was not brought over to nrunner yet is the "output check" feature. Issue https://github.com/avocado-framework/avocado/issues/3882 tracks that.