avocado-vt add qdevice

ID: 3253, 3262, 3269, 3393,3392,3388

Jan 24 '25 12:01 nickzhq

Hello @mcasquer @ybduan @aliang123 , Please review this patch and do the regression test if necessary. As you seeing, I've done the gating test on RHEL-9.3.0. @lkotek @YongxueHong @yanan-fu please review this patch, too. If you guys find issues, do NOT hesitate to slack me even if I'm on Chinese new year holidays.

cc to other maintainers: @luckyh @zhencliu

Thanks to you guys in advance!

Jan 27 '25 01:01 nickzhq

Test cases passed

 (1/3) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: STARTED
 (1/3) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: PASS (210.98 s)
 (2/3) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.nvdimm.nvdimm_hotplug.q35: STARTED
 (2/3) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.nvdimm.nvdimm_hotplug.q35: PASS (149.32 s)
 (3/3) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_virtio_mem.q35: STARTED
 (3/3) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_virtio_mem.q35: PASS (182.03 s)
RESULTS    : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Jan 27 '25 08:01 mcasquer

Hi @mcasquer and @nickzhq, I just tested the patch with RHEL 10:

JOB LOG    : /root/avocado/job-results/job-2025-01-28T07.38-1f7f8ad/job.log
 (1/1) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: STARTED
 (1/1) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: PASS (158.65 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

All good, thanks for the fix!

EDIT: And the same goes for the RHEL 9.6:

JOB ID     : 39861f4830089e9d902898e6eb3a8a3c6b26ec0d
JOB LOG    : /root/avocado/job-results/job-2025-01-28T08.18-39861f4/job.log
 (1/1) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: STARTED
 (1/1) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: PASS (138.53 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /root/avocado/job-results/job-2025-01-28T08.18-39861f4/results.html

Jan 28 '25 12:01 lkotek

Hello @nickzhq, hotplug_mem_negative.invalid_device_addr test case failed with current patch

 (1/1) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.hotplug_mem_negative.invalid_device_addr.q35: STARTED
 (1/1) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.hotplug_mem_negative.invalid_device_addr.q35: FAIL: No valid keywords were found in the qemu prompt message (117.08 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

More details internally

Jan 30 '25 07:01 mcasquer

Using the latest code of the patch, tests cases passed

RHEL 9.6 VM

 (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_virtio_mem.q35: STARTED
 (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_virtio_mem.q35: PASS (240.76 s)
 (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: STARTED
 (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_memory.after.guest_reboot.hotplug.backend_file.policy_default.two.q35: PASS (203.58 s)
 (3/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.nvdimm.nvdimm_hotplug.q35: STARTED
 (3/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.nvdimm.nvdimm_hotplug.q35: CANCEL: Install dependency packages failed (388.06 s)
 (4/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_mem_negative.invalid_device_addr.q35: STARTED
 (4/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.hotplug_mem_negative.invalid_device_addr.q35: PASS (56.85 s)
RESULTS    : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1

Windows 11 VM

 (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
 (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (4517.47 s)
 (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.hotplug_mem_negative.invalid_device_addr.q35: STARTED
 (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.hotplug_mem_negative.invalid_device_addr.q35: PASS (195.15 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Feb 05 '25 13:02 mcasquer

@yanglei-rh Hi,could you help check if this patch fix the 'mq' parameter's issue?

Feb 12 '25 05:02 nanliu-r

@yanglei-rh Hi,could you help check if this patch fix the 'mq' parameter's issue?

@nanliu-r Thanks for your reninder, I also can reproduced QMP command 'device_add' failed (arguments: OrderedDict([('id', 'idsgrDZU'), ('driver', 'virtio-net-pci'), ('netdev', 'idH6BZEn'), ('mac', '9a:2d:dd:d2:cf:84'), ('mq', 'on'), ('vectors', 10), ('bus', 'pcie_extra_root_port_0'), ('addr', '0x0')]), error message: {'class': 'GenericError', 'desc': "Invalid parameter type for 'mq', expected: boolean"}) affter apply this patch.

Feb 13 '25 03:02 yanglei-rh

@yanglei-rh Hi,could you help check if this patch fix the 'mq' parameter's issue?

@nanliu-r Thanks for your reninder, I also can reproduced QMP command 'device_add' failed (arguments: OrderedDict([('id', 'idsgrDZU'), ('driver', 'virtio-net-pci'), ('netdev', 'idH6BZEn'), ('mac', '9a:2d:dd:d2:cf:84'), ('mq', 'on'), ('vectors', 10), ('bus', 'pcie_extra_root_port_0'), ('addr', '0x0')]), error message: {'class': 'GenericError', 'desc': "Invalid parameter type for 'mq', expected: boolean"}) affter apply this patch.

Hello @yanglei-rh , after I've checked this patch, the 'mq' is set to related Boolean type in my host( QEMU emulator version 9.1.0 (qemu-kvm-9.1.0-11.el10) ). I wonder which qemu version you used to test this patch?

In addition, what's name of the test case you tested?

Thanks!

Feb 13 '25 05:02 nickzhq

Hello @yanglei-rh , Please test again. This patch is ready to support 'mq' arg in old qemu version.

Feb 13 '25 06:02 nickzhq

Acked-by: Aihua Liang[email protected] (1/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_cfg.legacy_cfg.q35: PASS (92.90 s) (2/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_cfg.vq_cfg.q35: PASS (72.90 s) (3/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_cfg.vq_rr.with_rounds.q35: PASS (72.40 s) (4/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_cfg.vq_rr.with_no_round.q35: PASS (72.20 s) (5/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_cfg.vq_full.q35: PASS (74.00 s) (6/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_negative.miss_vq.q35: PASS (8.14 s) (7/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_negative.over_vq.q35: PASS (8.18 s) (8/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_negative.overlap_vq.q35: PASS (8.16 s) (9/9) Host_RHEL.mx.u0.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_negative.miss_vqs.q35: PASS (8.15 s)

Feb 14 '25 02:02 aliang123

Test pass under virtio-net mq tests.

Feb 14 '25 03:02 yanglei-rh

Test pass under virtio-win-net with prewhql272 (Win10.i386 and Win2016.x86_64).

Feb 18 '25 03:02 heywji

Hello @YongxueHong @zhencliu @yanan-fu , any recommended comments on this patch? Thanks in advance!

Mar 04 '25 02:03 nickzhq

@YongxueHong Please check again, thanks!

Mar 12 '25 01:03 nickzhq

Hello @fbq815 @mcasquer , can you guys give an ACK on this patch if this patch works well for you.

Thanks in advance!

(60/60) Host_RHEL.m9.u0.v0.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.0.0.x86_64.io-github-autotest-qemu.stop_continue.stop_cont_only.q35: STARTED (60/60) Host_RHEL.m9.u0.v0.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.0.0.x86_64.io-github-autotest-qemu.stop_continue.stop_cont_only.q35: PASS (57.43 s) RESULTS : PASS 60 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Mar 12 '25 02:03 nickzhq

add qdevice_format module