avocado-vt icon indicating copy to clipboard operation
avocado-vt copied to clipboard

Revert "Fix outdated usage of numa_cell"

Open sathnaga opened this issue 4 years ago • 4 comments

This reverts commit 00b9939baafbd4f1f483909da08f7372e69d9956.

As it introduces below failure

type_specific.io-github-autotest-libvirt.libvirt_vcpu_plug_unplug.positive_test.vcpu_set.live.vm_operate.no_operation: ERROR: Attributes values should be str-type of int-type. (7.82 s)

avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-libvirt/libvirt/tests/src/libvirt_vcpu_plug_unplug.py", line 296, in run
ERROR|     topology_correction=topology_correction)
ERROR|   File "/usr/local/lib/python3.6/site-packages/virttest/libvirt_xml/vm_xml.py", line 868, in set_vm_vcpus
ERROR|     vmcpu_xml.set_numa_cell(vmcpu_xml.dicts_to_cells(nodexml_list))
ERROR|   File "/usr/local/lib/python3.6/site-packages/virttest/libvirt_xml/vm_xml.py", line 1925, in dicts_to_cells
ERROR|     raise TypeError('Attributes values should be str-type of int-type.')
ERROR| TypeError: Attributes values should be str-type of int-type.
ERROR|

sathnaga avatar Jan 19 '21 09:01 sathnaga

This revert helped fixing the issue, testcase run with

            smp = 4
            vcpu_cores = 4
            vcpu_threads = 1
            vcpu_sockets = 1
            sockets = 1
            cores = 4
            threads = 1
            numa = "yes"
 (1/3) io-github-autotest-qemu.unattended_install.import.import.default_install.aio_native: PASS (55.39 s)
 (2/3) type_specific.io-github-autotest-libvirt.libvirt_vcpu_plug_unplug.positive_test.vcpu_set.live.vm_operate.no_operation: PASS (107.05 s)
 (3/3) io-github-autotest-libvirt.remove_guest.without_disk: PASS (7.04 s)

sathnaga avatar Jan 19 '21 09:01 sathnaga

@sathnaga I checked latest test result of this case on power9, we have a PASS. So, could it be another reason that causes the failure? We're using avocado82lts, the lastest avocado-vt and tp-libvirt to run the test.

chloerh avatar Jan 20 '21 03:01 chloerh

positive_test.vcpu_set.live.vm_operate.no_operation 2 m 35 s Passed

chloerh avatar Jan 20 '21 03:01 chloerh

@sathnaga I checked latest test result of this case on power9, we have a PASS. So, could it be another reason that causes the failure? We're using avocado82lts, the lastest avocado-vt and tp-libvirt to run the test.

@chloerh bydefault testcase will be a pass, but try re-run with numa=yes and the cpu topology I mentioned in previous comment, and let me know if you could recreate.

I used avocado 83.0 and latest tp-libvirt tp-qemu.

sathnaga avatar Jan 20 '21 03:01 sathnaga