avocado-vt icon indicating copy to clipboard operation
avocado-vt copied to clipboard

Fail test when libvirtd fails to reload on time

Open ldoktor opened this issue 4 years ago • 1 comments

More and more often I'm getting weird failures on a very overloaded machine when the libvirtd fails to reload on time and they all look related to us using libvirt before it's started. Let's fail the test in such case during the setup instead of silently proceeding.

ldoktor avatar Feb 27 '20 18:02 ldoktor

Changes:

  • fixed the check for None (both None and False should fail)

Not changed:

  • the timeout as param/variable. I am open to turning it into a class variable if you insisted, but please re-consider the real user action in case they want to tweak it https://github.com/avocado-framework/avocado-vt/pull/2453/commits/4514fad0dba16841f019cc0ae7c0f2a1802b1ffc#r399023337

ldoktor avatar Apr 01 '20 13:04 ldoktor