avocado-vt icon indicating copy to clipboard operation
avocado-vt copied to clipboard

Published 20 hours ago • verified publisher icon avocado-framework

utils_test: remove python2/pip2 used for avocado installation

Open balamuruhans opened this issue 5 years ago • 6 comments

As avocado master stopped supporting python2, avoid installing and using avocado with python2/pip2 inside VM.

Signed-off-by: Balamuruhan S [email protected]

balamuruhans avatar Sep 23 '19 10:09 balamuruhans

In fact, this patch replaced python2 with python3

xutian avatar Nov 19 '19 08:11 xutian

@ldoktor mentioned this, and I agree: why not just change the order and give Python 3 priority, given that current Avocado-VT is still expected to work on Python 2?

clebergnu avatar Jun 17 '20 16:06 clebergnu

Yep, I'd suggest changing the order to python3, python2, python and maybe even explicit /usr/libexec/platform-python. The check should be pretty fast and this should cover most cases in the recommended order.

ldoktor avatar Jun 23 '20 17:06 ldoktor

Yep, I'd suggest changing the order to python3, python2, python and maybe even explicit /usr/libexec/platform-python. The check should be pretty fast and this should cover most cases in the recommended order.

@ldoktor @clebergnu I feel this is fine and we can remove python2 dependency and keep only python3, which is the patch trying to change, why do we need python2 reference now?

sathnaga avatar Jul 09 '20 14:07 sathnaga

Yep, I'd suggest changing the order to python3, python2, python and maybe even explicit /usr/libexec/platform-python. The check should be pretty fast and this should cover most cases in the recommended order.

@ldoktor @clebergnu I feel this is fine and we can remove python2 dependency and keep only python3, which is the patch trying to change, why do we need python2 reference now?

I'm not really affected by this and I haven't tried but does py2 setup work or is it doomed to fail? I can understand some people might need to test an old OS on a new OS (let's say RHEL7 on a RHEL8 machine) and might benefit from having the possibility to use py2 so I'd be inclined to just change the order and let them deal with the consequences. On the other hand I won't nack the py2 removal despite my preferences, users can always bring it back when needed.

ldoktor avatar Jul 15 '20 05:07 ldoktor

@sathnaga could you please send a rebased version of this PR? I think we should bring the discussion back (with a PR in mergeable state).

clebergnu avatar Mar 19 '21 20:03 clebergnu