avo icon indicating copy to clipboard operation
avo copied to clipboard

✨ Password: add reveal property

Open RocKhalil opened this issue 1 year ago • 5 comments
trafficstars

Description

In the password field, you can now add a property reveal to have an icon to reveal the password while writing it.

Fixes # (issue) related but not related to this: https://github.com/avo-hq/avo/issues/2168

Checklist:

  • [X] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Add reveal: true to password
  2. View the eye icon

RocKhalil avatar Oct 15 '24 08:10 RocKhalil

Code Climate has analyzed commit 88f99aa0 and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Oct 15 '24 08:10 qlty-cloud-legacy[bot]

related docs: https://github.com/avo-hq/docs.avohq.io/pull/298

RocKhalil avatar Oct 15 '24 08:10 RocKhalil

One quick piece of feedback. Can we rename the option from reveal (which is an action) to revealable? Thanks for your time @RocKhalil 💪

adrianthedev avatar Oct 16 '24 12:10 adrianthedev

One quick piece of feedback. Can we rename the option from reveal (which is an action) to revealable? Thanks for your time @RocKhalil 💪

hahaha yeah... I wanted to call it revealable but Paul and I were discussing it on Discord and we called it reveal :')

RocKhalil avatar Oct 16 '24 12:10 RocKhalil

😬

adrianthedev avatar Oct 16 '24 12:10 adrianthedev

@Paul-Bob done 👍

RocKhalil avatar Oct 22 '24 16:10 RocKhalil