avo
avo copied to clipboard
✨ Password: add reveal property
Description
In the password field, you can now add a property reveal to have an icon to reveal the password while writing it.
Fixes # (issue) related but not related to this: https://github.com/avo-hq/avo/issues/2168
Checklist:
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] I have added tests that prove my fix is effective or that my feature works
Manual review steps
- Add
reveal: trueto password - View the eye icon
Code Climate has analyzed commit 88f99aa0 and detected 0 issues on this pull request.
View more on Code Climate.
related docs: https://github.com/avo-hq/docs.avohq.io/pull/298
One quick piece of feedback.
Can we rename the option from reveal (which is an action) to revealable?
Thanks for your time @RocKhalil 💪
One quick piece of feedback. Can we rename the option from
reveal(which is an action) torevealable? Thanks for your time @RocKhalil 💪
hahaha yeah... I wanted to call it revealable but Paul and I were discussing it on Discord and we called it reveal :')
😬
@Paul-Bob done 👍