avo icon indicating copy to clipboard operation
avo copied to clipboard

Update date param to global_range

Open gabrielgiroe1 opened this issue 1 year ago • 1 comments

Description

Updated the query parameter in frame.src from date to global_range[date] in the updateCards method of card_filters_controller.js to reflect the new parameter naming convention. Related to dashboard-wide filters

Fixes # (issue)

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

gabrielgiroe1 avatar May 21 '24 06:05 gabrielgiroe1

Code Climate has analyzed commit 6f9fd82b and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar May 21 '24 06:05 qlty-cloud-legacy[bot]

What's the status on this?

adrianthedev avatar May 28 '24 07:05 adrianthedev

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

github-actions[bot] avatar May 28 '24 09:05 github-actions[bot]