Add TipTap Editor to AVO

[olivierbuffon]

trafficstars

Feature

Hey guys,

I've been working with Trix fields and hit some limitations that could be improved. I noticed there's a demand for extra features in the Trix community, but not much action on that front.

I found a thread (#1839) about possibly adding the TipTap editor to AVO, which sounds like a great solution. I've already put together a basic proof of concept using StimulusJS that looks promising.

Are you guys still open to adding TipTap to AVO? I think it could be a big win for the community, and I'm happy to work on it and submit a PR if you're interested.

Thanks for considering this!

[adrianthedev]

Yes, @olivierbuffon. We would definitely want to have TipTap as a default field. And yes, we'd love your contribution!

Do you need an approach from our end on how to tackle this?

[olivierbuffon]

@adrianthedev ok great news! Let's get this done. I think I'm good on how to make this work the AVO way! 😄
I'll try to tackle that in the next few days (I'm doing that on my spare time) and submit a first PR so you guys can give me your feedback 😃 !

[olivierbuffon]

Hey @adrianthedev just a quick update. Things are going well on my side. Here is what I came with for now:

I'd like your input on some points:

• I came with this basic version this few options. Do you think it's enough for a v0.1? So we can add other options later.
• Heroicons doesn't come with edition icons (like bold, italic etc...) so I used Lucide ones, any objection? Alternatives?
• For now, nothing is optional/configurable on this field (except the options that came from the AVO field inheritance), do you want me to add some for this version or do you want to add it in a second iteration?

Let me know if you have any other concern.

[adrianthedev]

1. Yes. Great for initial iteration. We do that as well. ship it first, then improve it.
2. good enough for now. I don't particularly like those, but let's ship it first.
3. It's up to you. I don't know anything about tip tap's options. But again, I'd go with the "let's ship it strategy" first. QWe can add those later and on a request basis.

Thank you for tackling this! You are an angel!

[olivierbuffon]

Thanks for the feedback! Well, we're on the same page then.

good enough for now. I don't particularly like those, but let's ship it first.

Haha me neither which is why I was asking for any known alternative. Anyway at least it's working and we understand what's behind.

It's up to you. I don't know anything about tip tap's options.

Well to be quick, the only thing you have to know it that TipTap out of the box is pretty much a simple "Text Area" that you can customize as you need. So every single button and behaviour is part of an extension that you need to implement.

Yes. Great for initial iteration. We do that as well. ship it first, then improve it.

Perfect, so I still need to tweak it a bit (especially for the "add link" part), improve the test coverage and we should be good to go (at least for the PR 😄 ).

I'll try my best to find time to wrap this up before the end of the week 🤞🏻

Cheers!

[adrianthedev]

This just hit me. Would it be compatible with Active Storage? We can add it later down the line, but I'm wondering... I know Konnor Rogers is working on https://github.com/konnorrogers/rhino-editor

[adrianthedev]

Actually, rhino is compatible with Active Text. But let's ship this version and then add Active Storage integration.

[adrianthedev]

Double correction. It seems to be working with both https://rhino-editor.vercel.app/tutorials/usage-with-rails/

[olivierbuffon]

Well I'm not an expert of Active Text and Active Storage but I'd say that for now, nothing's telling be that wouldn't be compatible. I'll take a look at it more deeply when the first version will be shipped (except if you're finding something that sounds like a deal breaker 😉 )

[github-actions[bot]]

This issue has been marked as stale because there was no activity for the past 15 days.