avo icon indicating copy to clipboard operation
avo copied to clipboard

Published 20 hours ago • verified publisher icon avo-hq

Rest API Resource select all feature breaks

Open Paul-Bob opened this issue 3 years ago • 1 comments

Describe the bug

We have implemented two rest API resources following this recipe: https://docs.avohq.io/2.0/recipes/rest-api-integration.html and after updating to Avo 2.14 it started throwing an exception (watch screenshot). The problem is, in our rest API based resources we don't have a DB query because our index rows are fetched from another application via API and they are not DB persistent models.

Screenshots

image

Impact

  • [x] High impact
  • [ ] Medium impact
  • [ ] Low impact

Urgency

  • [x] High urgency
  • [ ] Medium urgency
  • [ ] low urgency

Paul-Bob avatar Sep 23 '22 16:09 Paul-Bob

We should probably check to see if it responds to to_sql. I can't test it locally. Can you share a PR when you've got some time? I think return if @query.all.respond_to?(:to_sql).nil? in app/components/avo/index/resource_table_component.rb should fix it.

adrianthedev avatar Sep 27 '22 21:09 adrianthedev