avo icon indicating copy to clipboard operation
avo copied to clipboard

Published 20 hours ago • verified publisher icon avo-hq

add date-time filter

Open OlexYakov opened this issue 3 years ago • 5 comments
trafficstars

Description

Date-time filter. Enables the user to create filters by date or date-time, on any timestamp field. Relevant feature request #1226

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

OlexYakov avatar Sep 13 '22 14:09 OlexYakov

Code Climate has analyzed commit 522dafa4 and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Sep 13 '22 14:09 qlty-cloud-legacy[bot]

adrianthedev avatar Sep 13 '22 14:09 adrianthedev

Currently on vacation, I'll add tests and documentation when I come back, in a few days.

OlexYakov avatar Sep 13 '22 15:09 OlexYakov

Now worries man. Enjoy your time off! This is an amazing start!

adrianthedev avatar Sep 13 '22 15:09 adrianthedev

This PR has been marked as stale because there was no activity for the past 15 days.

github-actions[bot] avatar Sep 29 '22 04:09 github-actions[bot]

This needs a rebase

adrianthedev avatar Oct 17 '22 15:10 adrianthedev

Also, I wonder if we could use the native field components to render the inputs for the date filter.

adrianthedev avatar Oct 17 '22 15:10 adrianthedev

This PR has been marked as stale because there was no activity for the past 15 days.

github-actions[bot] avatar Nov 14 '22 02:11 github-actions[bot]

Closing for now. We'll probably land this in Avo 3

adrianthedev avatar Nov 29 '22 16:11 adrianthedev