avo icon indicating copy to clipboard operation
avo copied to clipboard

feature: batch delete

Open Paul-Bob opened this issue 2 years ago • 3 comments

Description

Fixes https://github.com/avo-hq/avo/issues/1172

batch delete

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works

Paul-Bob avatar Sep 10 '22 17:09 Paul-Bob

Code Climate has analyzed commit d961aa44 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Sep 10 '22 17:09 codeclimate[bot]

Codecov Report

Base: 94.29% // Head: 94.41% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (41c5504) compared to base (06d1f45). Patch has no changes to coverable lines.

:exclamation: Current head 41c5504 differs from pull request most recent head d961aa4. Consider uploading reports for the commit d961aa4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1224      +/-   ##
==========================================
+ Coverage   94.29%   94.41%   +0.12%     
==========================================
  Files         543      555      +12     
  Lines       10778    11279     +501     
==========================================
+ Hits        10163    10649     +486     
- Misses        615      630      +15     
Impacted Files Coverage Δ
...ec/dummy/app/controllers/avo/courses_controller.rb 78.94% <0.00%> (-21.06%) :arrow_down:
app/components/avo/filters_component.rb 92.30% <0.00%> (-7.70%) :arrow_down:
app/helpers/avo/application_helper.rb 64.28% <0.00%> (-6.73%) :arrow_down:
.../dummy/app/avo/resources/photo_comment_resource.rb 95.00% <0.00%> (-5.00%) :arrow_down:
app/components/avo/index/grid_item_component.rb 46.66% <0.00%> (-3.34%) :arrow_down:
app/controllers/avo/search_controller.rb 92.95% <0.00%> (-3.20%) :arrow_down:
.../avo/fields/common/single_file_viewer_component.rb 39.28% <0.00%> (-1.63%) :arrow_down:
app/controllers/avo/base_controller.rb 92.18% <0.00%> (-1.22%) :arrow_down:
lib/avo/licensing/h_q.rb 82.65% <0.00%> (-1.05%) :arrow_down:
app/components/avo/resource_component.rb 92.72% <0.00%> (-0.13%) :arrow_down:
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 14 '22 07:09 codecov[bot]

@adrianthedev i don't know if any documentation is needed for this one, it's intuitive and for now we don't have any configuration to enable/disable this feature

Paul-Bob avatar Sep 17 '22 12:09 Paul-Bob

The batch destroy logic approach should be decided by the developer for each project, closing this for now.

Paul-Bob avatar Oct 08 '22 10:10 Paul-Bob