avo
avo copied to clipboard
Resource links, rendered in tabs, not working as intended
Describe the bug
belongs_to links (and other links that do not have turbo disabled or target set) that are defined under tabs, don't work correctly.
Steps to Reproduce
- Go to show page of a resource that has tabs
- Press the link of a
belongs_tofield - Does not direct correctly to the associated resource
Expected behavior & Actual behavior
- Expected: Directs to the associated resource after pressing link
- Actual: stays on same page, tabs disappear
Screenshots


(From a different tab & field)

Notes
Adding target: "_top" to link_to in the belongs_to component solves the problem (but not sure if that is the correct approach)
System configuration
Avo version: 2.12.0 (also tested with 2.14.2)
Rails version: 6.1.6.1
Ruby version: 3.0.2
Impact
- [ ] High impact
- [] Medium impact
- [x] Low impact
Urgency
- [ ] High urgency
- [x] Medium urgency
- [ ] low urgency
Ok. I see the issue. Could you please use your workaround until we push a permanent fix? Thank you!
Hey, thanks for the note @nicholaswellens, actually that was my approach too, with a little tweak, we only apply target: "_top" when the field is inside a tab group
@Paul-Bob Great! Thanks for the fix! :+1: