avo icon indicating copy to clipboard operation
avo copied to clipboard

refactor: use inline_svg gem

Open adrianthedev opened this issue 2 years ago • 1 comments

Description

Fixes an issue where your local svgs were not accessible by Avo.

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

adrianthedev avatar Aug 12 '22 20:08 adrianthedev

Code Climate has analyzed commit 9e9012cb and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Aug 12 '22 20:08 codeclimate[bot]

Codecov Report

Base: 94.29% // Head: 94.26% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (9e9012c) compared to base (c48b47c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
- Coverage   94.29%   94.26%   -0.03%     
==========================================
  Files         546      549       +3     
  Lines       10864    10951      +87     
==========================================
+ Hits        10244    10323      +79     
- Misses        620      628       +8     
Impacted Files Coverage Δ
app/helpers/avo/application_helper.rb 62.26% <100.00%> (-8.76%) :arrow_down:
spec/dummy/config/initializers/avo.rb 94.23% <100.00%> (ø)
...ec/dummy/app/controllers/avo/courses_controller.rb 78.94% <0.00%> (-21.06%) :arrow_down:
app/controllers/avo/base_controller.rb 92.18% <0.00%> (-0.85%) :arrow_down:
spec/system/avo/default_field_spec.rb 95.12% <0.00%> (ø)
spec/dummy/app/avo/resources/fish_resource.rb 100.00% <0.00%> (ø)
spec/features/avo/readonly_takes_a_block_spec.rb 100.00% <0.00%> (ø)
...atures/avo/exposed_methods_base_controller_spec.rb 100.00% <0.00%> (ø)
lib/avo/fields/concerns/is_readonly.rb 100.00% <0.00%> (ø)
lib/avo/fields/base_field.rb 95.51% <0.00%> (+0.02%) :arrow_up:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 20 '22 09:08 codecov[bot]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

github-actions[bot] avatar Aug 22 '22 08:08 github-actions[bot]