avm19
avm19
This PR needs attention.
@jnothman Would you be able to review this PR or advise on how to proceed to get it merged in foreseeable future? I am asking you, because you thumbs-upped. Thanks!
@jnothman > > Titanic dataset ... > > Certainly sounds like a good place to start! > I don't think it's terribly harmful for us to just rename the parameter...
@jnothman Thanks for your previous comments and suggestions. Please have a further look at this PR. 1. Parameter `estimatorsNBs` was renamed to `nb_estimators`. 2. I added a titanic dataset [example](https://output.circle-artifacts.com/output/job/881a31a4-d004-4364-b726-dc7d802b7bf8/artifacts/0/doc/auto_examples/miscellaneous/plot_combining_naive_bayes.html),...
CI doc generation on CircleCI keeps failing due to connection timeout when `fetch_openml` retrieves the titanic dataset. Although addressed in #22529 , the problem persists. Everything's working fine on my...
> This PR needs a what's new entry in `doc/whats_new/v1.1.rst`. I doubt that it will land in v1.1, but for the moment, we can place the entry there. This should...
@agramfort Is there a chance you could review this PR or provide a feedback? Thanks in any case.
> @avm19 please see some comments @agramfort Many thanks for your comments and suggestions. I addressed all of them. Since I am not too sure about the etiquette, I am...
Working on changes towards #23462 .
> Working on changes towards #23462 . Done. A note added to the head message. A custom replacement for `test_common.py::test_check_param_validation` is implemented in `test_naive_bayes.py::test_cwnb_check_param_validation`. It is needed because `utils.estimator_checks._construct_instance` does...