BlizzardApiReader icon indicating copy to clipboard operation
BlizzardApiReader copied to clipboard

Add SC2 Community API

Open avivbiton opened this issue 6 years ago • 7 comments

The api docs can be found here https://dev.battle.net/io-docs

avivbiton avatar Jun 27 '18 21:06 avivbiton

I can spend some time on Sunday creating some model classes for this.

markfila avatar Oct 03 '18 22:10 markfila

okay thanks

avivbiton avatar Oct 04 '18 14:10 avivbiton

Hi avivbiton and markfila,

Is this still being worked on or is this something I could have a go at? I have some free time this weekend.

Thanks Oisin

oisinmcl avatar Jan 11 '19 22:01 oisinmcl

I started working on this, but when I went to try some of the calls, I didn't see that blizzard setup a test account like with the wow ones. I couldn't figure out how to find the information on my blizzard account to be able to enter it into the parameters blizzard needs on documentation site in order to see how the responses come back. If you want to take a stab at it, I haven't committed anything.

markfila avatar Jan 15 '19 20:01 markfila

Hi markfila,

I will work on this when I have free time here and there. As you say, getting the info needed to run a request was a bit tricky but now to decipher the responses.

Thanks

oisinmcl avatar Feb 10 '19 22:02 oisinmcl

@avivbiton what are the rules on coverage of the API before creating a pull request? I have some endpoints return empty objects due to my account not having that specific data.

Also if you had time could you review my fork to see if there is anything obvious am I doing wrong/doesn't conform.

oisinmcl avatar Feb 17 '19 13:02 oisinmcl

@oisinmcl As long as it works and you leave a comment saying it's unfinished. We don't have documentation set up, just a TODO comment should be fine for now.
I've been pushing with other personal projects lately, I'll come back to this project later, meanwhile It still open for pull requests and I'm still actively responding to issues.
Don't be afraid to make a pull request, even if it has some problems we can comment in your pull requests and allow you to make changes before pushing it into the main branch.

avivbiton avatar Feb 17 '19 19:02 avivbiton