iosevka-docker
iosevka-docker copied to clipboard
Feedback from davidino
Some feedback from @dcasella
-
[ ] ! -n -> -z
if [ ! -n "$FONT_VERSION" ]; then
can beif [ -z "$FONT_VERSION" ]; then
so you can remove the ! -
[ ] decide to use
[
ortest
for every if statemant
if ! test -f "/build/private-build-plans.toml"; then
-> if [ ! -f '/build/private-build-plans.toml' ]; then
- [ ] recheck the parsing of the curl output