iosevka-docker icon indicating copy to clipboard operation
iosevka-docker copied to clipboard

Feedback from davidino

Open avivace opened this issue 4 years ago • 0 comments

Some feedback from @dcasella

  • [ ] ! -n -> -z if [ ! -n "$FONT_VERSION" ]; then can be if [ -z "$FONT_VERSION" ]; then so you can remove the !

  • [ ] decide to use [ or test for every if statemant

if ! test -f "/build/private-build-plans.toml"; then -> if [ ! -f '/build/private-build-plans.toml' ]; then

  • [ ] recheck the parsing of the curl output

avivace avatar Nov 26 '20 20:11 avivace