Andrew Vit

Results 47 comments of Andrew Vit

Those keys come from rails-i18n so we'll need them to allow IceCube to work without Rails. It's all a bit mixed up, some are under `ice_cube.date.defaults` and some are top-level...

Icalendar seems to be the right tool for the job. I think it makes sense if we start using it for import/export. It has no extra runtime dependencies (same as...

The smallest unit that IceCube works with is 1 second: milliseconds are dropped. I think here because you are trying to jump from `00:00:00` to the previous occurrence at `23:59:59.99999`,...

Well, let's look at the options: ### "Numeric" values ``` schedule.duration = 3600 # SECONDS, unchanged schedule.duration = 1.month # MONTH if recognizable via ActiveSupport ``` ### Hash value (Seems...

I'm not able to reproduce your first example. Can you give a little more context? (versions etc.) ``` require 'active_support/time' #=> true s = IceCube::Schedule.new(Time.now.change(sec: 0)) do |s| s.add_recurrence_rule(IceCube::Rule.weekly.day(:monday).hour_of_day(8)) end...

We should absolutely reference Tickle instead of reinventing the wheel. Thanks for the link @zoombody. It looks like it would be relatively simple to add your own IceCube::LanguageParser based on...

Also, we could probably reject recurrence rules that are completely masked by exception rules before even processing them. But I wonder if it's worth it... How do you arrive at...

@seejohnrun, @forrest, Did you have any more progress with the approach from pull request #112? Agreed on your comment that it should be more functional-style, but I also think we...

Gotcha, that makes sense. I was first thinking of a simpler solution using ruby's "retry" in the next_time method to avoid dealing with the instance variable state, but extracting to...

EXRULE is deprecated, IceCube should follow suit with that. Still, it's possible to create impossible combinations such as: ``` Rule.daily.day_of_month(30).month_of_year(2) Rule.daily.day_of_month(30).day_of_week(:monday => [1]) ``` I will add checks for conflicts...