fast-sqlite3-inserts icon indicating copy to clipboard operation
fast-sqlite3-inserts copied to clipboard
verified publisher icon avinassh

Code clean up / refactor

Open avinassh opened this issue 4 years ago • 3 comments

Rust versions are bad, could use some love in refactoring

secondly, a lot of code is repeated. applying DRY would make it better

avinassh avatar Jul 17 '21 16:07 avinassh

On a side note about refactor, why do you need 1 and 2?

darleybarreto avatar Jul 25 '21 12:07 darleybarreto

@darleybarreto those prepare the batch in a vector, which is later sent to writer over a channel

avinassh avatar Jul 25 '21 12:07 avinassh

Hmm. I'm confused, aren't you sending vector in both tx.send(ParamValues::WithArea(vector)).unwrap();/tx.send(ParamValues::WithoutArea(vector)).unwrap();?

darleybarreto avatar Jul 25 '21 13:07 darleybarreto