Avi Kivity comments

Results 1247 comments of


                                            Avi Kivity

Tests fail in CI due to "Disk error: std::system_error (error system:12, Cannot allocate memory)"

What kernel is this running on? Maybe we hit a bad kernel.

Lrge allocation threshold never goes down

Startup disables large allocation reporting, but the rest of it holds.

sstables_loader: report progress with the unit of batch

> Use "batch" as the unit of progress instead of individual sstables What is a "batch" unit? Can't we use bytes?

build: add soname to shared libraries

Please explain in the patch changelog why we're making this change.

build: add soname to shared libraries

> > @bkmgit hi Benson, just out of curiosity, do you really plan to package seastar for a distro like fedora? > > https://bugzilla.redhat.com/show_bug.cgi?id=2321986 > > DPDK is already there,...

treewide: move log.hh into utils/log.hh

I think the problem is with the cmake implementation. It doesn't test the header file in the same way it is used. How will anyone guess what the rules are?

treewide: move log.hh into utils/log.hh

I agree moving it to utils/ makes independent sense.

build: s/wasm32-wasi/wasm32-wasip1/

I don't see a reason to remove the compatibility so soon.

[x86_64, debug] topology_random_failures/test_random_failures failed with

Seen again: https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/13738/testReport/junit/topology_random_failures/test_random_failures/Tests___Unit_Tests___test_random_failures_stop_after_streaming_restart_coordinator_node__debug_2/ https://github.com/scylladb/scylladb/pull/21834

generic server: 2 step shutdown

> > ### Two-step shutdown for `generic_server` I counted three phases