Avi Kivity comments

Results 552 comments of


                                            Avi Kivity

storage_proxy: use consistent topology, prepare for fencing

/cc @tgrabiec , this prepares fencing

storage_proxy: use consistent topology, prepare for fencing

I dequeued it. There was a logical conflict - seperate series added the same method simultaneously, but in different lines. The compiler objected.

storage_proxy: use consistent topology, prepare for fencing

v2: - dropped first patch (conflicted with identical e541009f653c0425956c0668fb4d528d18043a1a which made it in first)

Can not restart scylla-server normally after "bad_alloc"

Was this before you disabled hints?

unset value is evil

Plan for fixing: - update the prepare code to determine which bind variable can be unset - initially, all can be unset - when preparing in a context that doesn't...

> > @cvybhu please take a look at the suggested fix plan ([#11143 (comment)](https://github.com/scylladb/scylladb/issues/11143#issuecomment-1197114560)). In particular: > > ``` > > 1. if you have any remarks > > >...

read path validation found many missing partition-end issues

@denesb didn't you break it up into separate issues? If so let's close this and discuss each individual issue on its page.

Failed to obtain stats (seastar::metrics::double_registration (registering metrics twice for metrics: storage_proxy_coordinator_background_replica_writes_failed_remote_node)), fall-back to dummy

/cc @elcallio, looks like listener restart forgets to unregister metrics

Failed to obtain stats (seastar::metrics::double_registration (registering metrics twice for metrics: storage_proxy_coordinator_background_replica_writes_failed_remote_node)), fall-back to dummy

@eliransin may be related to per-scheduling-group stats

Calculate effective_replication_map: prevent stalls with everywhere_replication_strategy

Very good.